Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-ary combining operators with tuples. #1375

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Conversation

bartdesmet
Copy link
Collaborator

@bartdesmet bartdesmet commented Oct 5, 2020

Addresses feature request #1269 per the discussion over there:

  • These are added in [O|Q]bservableEx to avoid conflicts with existing static methods calls, e.g. Observable.Zip(xs, ys).
  • Limiting to 8 overloads, to align with ValueTuple.Create overloads.
  • Properly layered through the IQueryLanguageEx intermediary (no plans to remove that mechanism).
  • Implementation delegates to underlying operator implementation by providing a selector.
    • Note that specialized implementations would be possible, but code size is a concern.
    • Let's keep it like this, with a selector, unless someone really has a performance concern about the delegate invocations.

Supports CombineLatest (8 overloads), Zip (8 overloads + IEnumerable<T> variant), and WithLatestFrom (1 overload).

@bartdesmet bartdesmet merged commit 460c58f into main Oct 5, 2020
@bartdesmet bartdesmet deleted the dev/bartde/nary_with_tuple branch October 5, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant